[Public] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP, (1080p 60hz [5650U]) (1920x1200 60hz [6600U]) (2560x1600 120hz[6600U]) VGA and DVI (1680x1050 60HZ [DP to VGA/DVI, USB-C to DVI/VGA]) DP/HDMI/USB-C (1440p 170hz, 4k 60hz, 4k 144hz [Includes USB-C to DP/HDMI adapters]) MST tested with Startech MST14DP123DP and 2x 4k 60Hz displays DSC tested with Cable Matters 101075 (DP to 3x DP), and 201375 (USB-C to 3x DP) with 3x 4k60 displays HP Hook G2 with 1 and 2 4k60 Displays The testing is a mix of automated and manual tests. Manual testing includes (but is not limited to): Changing display configurations and settings Benchmark testing Feature testing (Freesync, etc.) Automated testing includes (but is not limited to): Script testing (scripts to automate some of the manual checks) IGT testing The patchset consists of the amd-staging-drm-next branch (Head commit aaac77ad65330444aa506614529bb7883e024d9e -> Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL") with new patches added on top of it. This branch is used for both Ubuntu and Chrome OS testing (ChromeOS on a bi-weekly basis). Tested on Ubuntu 22.04.1 and Chrome OS Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx> Thank you, Dan Wheeler Sr. Technologist | AMD SW Display ------------------------------------------------------------------------------------------------------------------ 1 Commerce Valley Dr E, Thornhill, ON L3T 7X6 amd.com -----Original Message----- From: Zhuo, Qingqing (Lillian) <Qingqing.Zhuo@xxxxxxx> Sent: February 22, 2023 1:40 AM To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>; Lakha, Bhawanpreet <Bhawanpreet.Lakha@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Pillai, Aurabindo <Aurabindo.Pillai@xxxxxxx>; Zhuo, Qingqing (Lillian) <Qingqing.Zhuo@xxxxxxx>; Li, Roman <Roman.Li@xxxxxxx>; Lin, Wayne <Wayne.Lin@xxxxxxx>; Wang, Chao-kai (Stylon) <Stylon.Wang@xxxxxxx>; Chiu, Solomon <Solomon.Chiu@xxxxxxx>; Kotarac, Pavle <Pavle.Kotarac@xxxxxxx>; Gutierrez, Agustin <Agustin.Gutierrez@xxxxxxx>; Wheeler, Daniel <Daniel.Wheeler@xxxxxxx> Subject: [PATCH 00/20] DC Patches Feb 27th, 2023 This DC patchset brings improvements in multiple areas. In summary, we highlight: - Correct DML calculation - Extend Freesync over Pcon support - Fixes in pstate hang and more - Code cleanup for dc_link.h and dc_link.c Cc: Daniel Wheeler <daniel.wheeler@xxxxxxx> Alex Hung (1): drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes Alvin Lee (1): drm/amd/display: DAL to program DISPCLK WDIVIDER if PMFW doesn't Aric Cyr (6): drm/amd/display: Reduce CPU busy-waiting for long delays Revert "drm/amd/display: Do not set DRR on pipe commit" Revert "drm/amd/display: Fix FreeSync active bit issue" drm/amd/display: Do not update DRR while BW optimizations pending drm/amd/display: Only wait for blank completion if OTG active drm/amd/display: Promote DAL to 3.2.224 Ayush Gupta (1): drm/amd/display: populate subvp cmd info only for the top pipe Hersen Wu (1): drm/amd/display: dcn32/321 dsc_pg_control not executed properly Jasdeep Dhillon (1): drm/amd/display: Updating Video Format Fall Back Policy. Mustapha Ghaddar (2): drm/amd/display: Allocation at stream Enable drm/amd/display: Update BW ALLOCATION Function declaration Paul Hsieh (1): drm/amd/display: Correct DML calculation as HW SpreadSheet Ryan Lin (1): drm/amd/display: Ext displays with dock can't recognized after resume Samson Tam (1): drm/amd/display: enable DPG when disabling plane for phantom pipe Sung Joon Kim (1): drm/amd/display: Extend Freesync over PCon support for more devices Wenjing Liu (2): drm/amd/display: merge dc_link.h into dc.h and dc_types.h drm/amd/display: remove empty dc_link.c Yihan Zhu (1): drm/amd/display: update pixel format in DP hw sequence .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 1 + .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 + .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 4 +- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 41 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 253 +++----- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 27 - .../drm/amd/display/dc/core/dc_link_exports.c | 87 +++ drivers/gpu/drm/amd/display/dc/dc.h | 556 +++++++++++++++++- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 3 +- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 107 ++++ drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 14 + drivers/gpu/drm/amd/display/dc/dc_link.h | 8 +- drivers/gpu/drm/amd/display/dc/dc_types.h | 104 ++++ drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 9 +- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.h | 5 +- .../display/dc/dce110/dce110_hw_sequencer.c | 2 +- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c | 9 + .../dc/dcn30/dcn30_dio_stream_encoder.c | 1 + .../drm/amd/display/dc/dcn30/dcn30_hwseq.c | 10 +- .../dc/dcn31/dcn31_hpo_dp_link_encoder.c | 1 - .../dc/dcn31/dcn31_hpo_dp_stream_encoder.c | 2 +- .../dc/dcn314/dcn314_dio_stream_encoder.c | 6 + .../dc/dcn32/dcn32_hpo_dp_link_encoder.c | 1 - .../drm/amd/display/dc/dcn32/dcn32_hwseq.c | 21 +- .../drm/amd/display/dc/dcn32/dcn32_resource.c | 1 + .../amd/display/dc/dcn321/dcn321_resource.c | 1 + .../dc/dml/dcn30/display_mode_vba_30.c | 6 +- .../dc/dml/dcn31/display_mode_vba_31.c | 299 ++++++---- .../dc/dml/dcn314/display_mode_vba_314.c | 299 ++++++---- .../dc/dml/dcn32/display_mode_vba_32.c | 1 - .../gpu/drm/amd/display/dc/inc/hw/hw_shared.h | 14 - .../drm/amd/display/dc/inc/hw/link_encoder.h | 52 -- .../amd/display/dc/inc/hw/stream_encoder.h | 1 - drivers/gpu/drm/amd/display/dc/inc/link.h | 1 - .../display/dc/link/accessories/link_dp_cts.c | 17 - .../drm/amd/display/dc/link/link_detection.c | 99 ++++ .../gpu/drm/amd/display/dc/link/link_dpms.c | 15 +- .../amd/display/dc/link/protocols/link_ddc.h | 1 + .../dc/link/protocols/link_dp_capability.c | 10 +- .../display/dc/link/protocols/link_dp_dpia.c | 1 - .../dc/link/protocols/link_dp_dpia_bw.c | 38 +- .../dc/link/protocols/link_dp_dpia_bw.h | 14 +- .../dc/link/protocols/link_dp_training.c | 7 +- .../dc/link/protocols/link_dp_training_dpia.c | 3 +- .../link/protocols/link_edp_panel_control.c | 4 +- .../amd/display/include/link_service_types.h | 26 - .../amd/display/modules/freesync/freesync.c | 12 +- .../drm/amd/display/modules/inc/mod_hdcp.h | 1 + 54 files changed, 1618 insertions(+), 606 deletions(-) delete mode 100644 drivers/gpu/drm/amd/display/dc/core/dc_link.c -- 2.34.1