On 1/31/23 11:05, Melissa Wen wrote: > Cursor gets clipped off in the middle of the screen with hw rotation > 180. Fix a miscalculation of cursor offset when it's placed near the > edges in the pipe split case. > > Cursor bugs with hw rotation were reported on AMD issue tracker: > https://gitlab.freedesktop.org/drm/amd/-/issues/2247 > > The issues on rotation 270 was fixed by: > https://lore.kernel.org/amd-gfx/20221118125935.4013669-22-Brian.Chang@xxxxxxx/ > that partially addressed the rotation 180 too. So, this patch is the > final bits for rotation 180. > > Reported-by: Xaver Hugl <xaver.hugl@xxxxxxxxx> > Fixes: 9d84c7ef8a87 ("drm/amd/display: Correct cursor position on horizontal mirror") > Signed-off-by: Melissa Wen <mwen@xxxxxxxxxx> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx> Harry > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > index bb155734ac93..480c0b3b51fc 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > @@ -3624,7 +3624,7 @@ void dcn10_set_cursor_position(struct pipe_ctx *pipe_ctx) > (int)hubp->curs_attr.width || pos_cpy.x > <= (int)hubp->curs_attr.width + > pipe_ctx->plane_state->src_rect.x) { > - pos_cpy.x = temp_x + viewport_width; > + pos_cpy.x = 2 * viewport_width - temp_x; > } > } > } else {
