>> Nope, that is not related to any hw state.
can use other flag.
>> It's simply not allowed to free up resources during suspend since those can't be acquired again during resume.
The in_suspend flag is set at the beginning of suspend and unset at the end of resume. It can’t filter the case you mentioned.
Do you know the root cause of these cases hitting the issue? So that we can get an exact point to warn the freeing up behavior.
Thanks,
Jack
From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>
Sent: Friday, February 3, 2023 9:20 PM
To: Xiao, Jack <Jack.Xiao@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: only WARN freeing buffers when DMA is unavailable
Nope, that is not related to any hw state.
It's simply not allowed to free up resources during suspend since those can't be acquired again during resume.
We had a couple of cases now where this was wrong. If you get a warning from that please fix the code which tried to free something during suspend instead.
Regards,
Christian.
Am 03.02.23 um 07:04 schrieb Xiao, Jack:
>> It's simply illegal to free up memory during suspend.
Why? In my understanding, the limit was caused by DMA shutdown.
Regards,
Jack
Big NAK to this! This warning is not related in any way to the hw state.
It's simply illegal to free up memory during suspend.
Reduce waringings, only warn when DMA is unavailable.
Signed-off-by: Jack Xiao <Jack.Xiao@xxxxxxx>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 2d237f3d3a2e..e3e3764ea697 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -422,7 +422,8 @@ void amdgpu_bo_free_kernel(struct amdgpu_bo **bo, u64 *gpu_addr,
if (*bo == NULL)
return;
- WARN_ON(amdgpu_ttm_adev((*bo)->tbo.bdev)->in_suspend);
+ WARN_ON(amdgpu_ttm_adev((*bo)->tbo.bdev)->in_suspend &&
+ !amdgpu_ttm_adev((*bo)->tbo.bdev)->ip_blocks[AMD_IP_BLOCK_TYPE_SDMA].status.hw);
if (likely(amdgpu_bo_reserve(*bo, true) == 0)) {
if (cpu_addr)
--
2.37.3
|
