Looks good to me. WIth a link the mesa MR which uses these, the patch is: Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> For TA_CNTL2, an alternative would be to add this register to the AMDGPU_INFO_READ_MMR_REG and just cache it in the KGD if you think we may need other fields from it in the future. Alex On Mon, Jan 30, 2023 at 12:57 AM Marek Olšák <maraeo@xxxxxxxxx> wrote: > > AMDGPU_IDS_FLAGS_CONFORMANT_TRUNC_COORD: important for conformance on gfx11 > Other fields are exposed from IP discovery. > enabled_rb_pipes_mask_hi is added for future chips, currently 0. > > The patch is attached. > > Thanks, > Marek
