Re: [PATCH] drm/amd/display: use a more appropriate return value in dp_retrieve_lttpr_cap()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

On Fri, Jan 20, 2023 at 12:31 PM Hamza Mahfooz <hamza.mahfooz@xxxxxxx> wrote:
>
> Not all ASICs support LTTPR, however if they don't it doesn't mean that
> we have encountered unexpected behaviour. So, use DC_NOT_SUPPORTED
> instead of DC_ERROR_UNEXPECTED.
>
> Reviewed-by: Wenjing Liu <wenjing.liu@xxxxxxx>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
> index e72ad1b8330f..21fd9275ae4c 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_dp_capability.c
> @@ -1462,7 +1462,7 @@ enum dc_status dp_retrieve_lttpr_cap(struct dc_link *link)
>         bool vbios_lttpr_interop = link->dc->caps.vbios_lttpr_aware;
>
>         if (!vbios_lttpr_interop || !link->dc->caps.extended_aux_timeout_support)
> -               return DC_ERROR_UNEXPECTED;
> +               return DC_NOT_SUPPORTED;
>
>         /* By reading LTTPR capability, RX assumes that we will enable
>          * LTTPR extended aux timeout if LTTPR is present.
> --
> 2.39.0
>



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux