On 01/17, Joshua Ashton wrote:
> This was never filled in and thus never truly used.
>
> Checking the EDID for content_type support is not required for sending
> the avi infoframe packet.
>
> Signed-off-by: Joshua Ashton <joshua@xxxxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/dc_stream.h | 1 -
> drivers/gpu/drm/amd/display/dc/dc_types.h | 14 --------------
> 2 files changed, 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_stream.h b/drivers/gpu/drm/amd/display/dc/dc_stream.h
> index 51dc30706e43..a499c0952ea0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_stream.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_stream.h
> @@ -182,7 +182,6 @@ struct dc_stream_state {
> */
> struct link_encoder *link_enc;
> struct dc_panel_patch sink_patches;
> - union display_content_support content_support;
> struct dc_crtc_timing timing;
> struct dc_crtc_timing_adjust adjust;
> struct dc_info_packet vrr_infopacket;
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_types.h b/drivers/gpu/drm/amd/display/dc/dc_types.h
> index c73a655bd687..862af36027e7 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_types.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc_types.h
> @@ -175,18 +175,6 @@ struct dc_edid {
>
> #define AUDIO_INFO_DISPLAY_NAME_SIZE_IN_CHARS 20
>
> -union display_content_support {
> - unsigned int raw;
> - struct {
> - unsigned int valid_content_type :1;
> - unsigned int game_content :1;
> - unsigned int cinema_content :1;
> - unsigned int photo_content :1;
> - unsigned int graphics_content :1;
> - unsigned int reserved :27;
> - } bits;
> -};
> -
> struct dc_panel_patch {
> unsigned int dppowerup_delay;
> unsigned int extra_t12_ms;
> @@ -219,8 +207,6 @@ struct dc_edid_caps {
> uint32_t audio_latency;
> uint32_t video_latency;
>
> - union display_content_support content_support;
> -
LGTM.
It depends on the previous patch, but if the first patch are fine, they
are both:
Reviewed-by: Melissa Wen <mwen@xxxxxxxxxx>
CC'ing AMD DC folks again since I don't know if it's in use by other
platforms. But it'd be nice to get rid of this or have a
comment/explanation, if not.
> uint8_t qs_bit;
> uint8_t qy_bit;
>
> --
> 2.39.0
>
Attachment:
signature.asc
Description: PGP signature
