Hi Am 16.01.23 um 19:37 schrieb Alex Deucher:
On Mon, Jan 16, 2023 at 11:20 AM Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote:On Mon, 16 Jan 2023, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:A lot of source files include drm_crtc_helper.h for its contained include statements. This leads to excessive compile-time dependencies. Where possible, remove the include statements for drm_crtc_helper.h and include the required source files directly. Also remove the include statements from drm_crtc_helper.h itself, which doesn't need most of them. I built this patchset on x86-64, aarch64 and arm. Hopefully I found all include dependencies.I think this is the right direction and I support this. Personally I think it's enough to build test and fix any fallout afterwards. To that end, I did build test this myself with my config, and it was fine, though that probably doesn't add much coverage. FWIW, Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>Agreed. I applied 1/22 since it was an unrelated cleanup, but the rest of the series is: Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
Thanks to both of you. I'll leave out the first patch when merging the series.
Best regards Thomas
-- Jani Nikula, Intel Open Source Graphics Center
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
