Re: [PATCH 2/3] drm/amdgpu/vcn: Deduplicate indirect SRAM checking code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/01/2023 18:49, Limonciello, Mario wrote:
> [...] 
> 
> The problem with adding a comment about which platform it's in is that
> this will probably go stale.  Some IP blocks are re-used in multiple ASICs.
> 
> VCN 3, 1, 1 is a great example.  This is used in both Yellow Carp (Rembrandt) as well
> as Mendocino.   I would think a better approach would be to have a single point
> of documentation somewhere in the source tree that we can update after new
> ASICs launch that could act as a decoder ring.
> 
> It's effort to remember to update it, but it's at least a single point of failure.
> 

Hi Mario, thanks - it makes a lot of sense! I can remove the comments in
the V2, I'll wait a bit more for (potential) extra feedback but I agree
with you, so I'm inclined to remove them.

Cheers,


Guilherme



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux