[AMD Official Use Only - General]
Tested-by: Candice Li <candice.li@xxxxxxx>
Thanks,
Candice
-----Original Message-----
From: Alex Deucher <alexdeucher@xxxxxxxxx>
Sent: Saturday, January 14, 2023 12:48 AM
To: Christian König <ckoenig.leichtzumerken@xxxxxxxxx>
Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Li, Candice <Candice.Li@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: fix cleaning up reserved VMID on release
On Fri, Jan 13, 2023 at 11:35 AM Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
>
> We need to reset this or otherwise run into list corruption later on./
Drop the / above.
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
>
> Fixes: 16be3e9f6f03 ("drm/amdgpu: rework reserved VMID handling")
> Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> index 6481b43ffe25..a0545d51b6bd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> @@ -499,6 +499,7 @@ void amdgpu_vmid_free_reserved(struct amdgpu_device *adev,
> !--id_mgr->reserved_use_count) {
> /* give the reserved ID back to normal round robin */
> list_add(&id_mgr->reserved->list, &id_mgr->ids_lru);
> + id_mgr->reserved = NULL;
> }
> vm->reserved_vmid[vmhub] = false;
> mutex_unlock(&id_mgr->lock);
> --
> 2.34.1
>
