On 1/13/23 14:06, Simon Ser wrote:
Hm, unfortunately I think we need to keep the check in amdgpu for the same reason as i915: amdgpu will pick a modifier if user-space didn't supply one on GFX9+. I wonder if that also applies to vmwgfx? Maybe that would be a reason to have the check in framebuffer_init()? (Not sure!)
Considering that we could then remove the check from i915 and amdgpu if we move the check to framebuffer_init(), I believe that this would be a good reason to perform the check there. I'll send a v4 including the check on framebuffer_init() and removing the check from i915. Thanks for the feedback! Best Regards, - Maíra Canal