On Thu, Jan 12, 2023 at 04:37:01PM -0600, Mario Limonciello wrote: > Some dead code was introdcued as part of utilizing the `amdgpu_ucode_*` > helpers. Adjust the control flow to make sure that firmware is released > in the appropriate error flows. > > Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> > Addresses-Coverity-ID: 1530548 ("Control flow issues") > Fixes: ec787deb2ddf ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX9") > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook