On Wed, Jan 11, 2023 at 02:02:02PM +0100, Thomas Zimmermann wrote:
> Define enum mode_set_atomic next to the only interface that uses
> the type. This will allow for removing several include statements
> for drm_fb_helper.h. No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> include/drm/drm_fb_helper.h | 5 -----
> include/drm/drm_modeset_helper_vtables.h | 6 +++++-
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index b111dc7ada78..f443e1f11654 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -37,11 +37,6 @@ struct drm_fb_helper;
>
> #include <drm/drm_client.h>
>
> -enum mode_set_atomic {
> - LEAVE_ATOMIC_MODE_SET,
> - ENTER_ATOMIC_MODE_SET,
> -};
> -
> /**
> * struct drm_fb_helper_surface_size - describes fbdev size and scanout surface size
> * @fb_width: fbdev width
> diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
> index 77a540ad7dcd..206f495bbf06 100644
> --- a/include/drm/drm_modeset_helper_vtables.h
> +++ b/include/drm/drm_modeset_helper_vtables.h
> @@ -48,10 +48,14 @@
> * To make this clear all the helper vtables are pulled together in this location here.
> */
>
> -enum mode_set_atomic;
> struct drm_writeback_connector;
> struct drm_writeback_job;
>
> +enum mode_set_atomic {
> + LEAVE_ATOMIC_MODE_SET,
> + ENTER_ATOMIC_MODE_SET,
> +};
> +
> /**
> * struct drm_crtc_helper_funcs - helper operations for CRTCs
> *
> --
> 2.39.0
--
Ville Syrjälä
Intel
