[AMD Official Use Only - General] Anyone else can help to review this patch series? We need these to address the fan speed setting failure reported for the new SMU13 asics. @Deucher, Alexander ? Evan > -----Original Message----- > From: Quan, Evan <Evan.Quan@xxxxxxx> > Sent: Thursday, January 5, 2023 11:23 AM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Quan, Evan > <Evan.Quan@xxxxxxx> > Subject: [PATCH 8/8] drm/amd/pm: drop the support for manual fan speed > setting on SMU13.0.7 > > Due to lack of support from PMFW. > > Signed-off-by: Evan Quan <evan.quan@xxxxxxx> > Change-Id: I8439e72b95ad2fdf8cfdf1edc4d9c8af58109dc3 > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c > index 3608540f2034..c7fa203ec7e8 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c > @@ -1736,4 +1736,9 @@ void smu_v13_0_7_set_ppt_funcs(struct > smu_context *smu) > > BIT_ULL(AMD_SYSFS_IF_PP_DPM_DCEFCLK_BIT) | > > BIT_ULL(AMD_SYSFS_IF_PP_SCLK_OD_BIT) | > > BIT_ULL(AMD_SYSFS_IF_PP_MCLK_OD_BIT)); > + /* Drop the support for manual fan speed(RPM and PWM) setting */ > + smu->adev- > >pm.hwmon_if_attr_mode[AMD_HWMON_IF_PWM1_ENABLE_BIT] &= > ~S_IWUSR; > + smu->adev- > >pm.hwmon_if_attr_mode[AMD_HWMON_IF_PWM1_BIT] &= ~S_IWUSR; > + smu->adev- > >pm.hwmon_if_attr_mode[AMD_HWMON_IF_FAN1_ENABLE_BIT] &= > ~S_IWUSR; > + smu->adev- > >pm.hwmon_if_attr_mode[AMD_HWMON_IF_FAN1_TARGET_BIT] &= > ~S_IWUSR; > } > -- > 2.34.1
