Re: [PATCH 2/2] drm/amdgpu: fix missing dma_fence_put in error path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 05.01.23 um 17:50 schrieb Alex Deucher:
On Thu, Jan 5, 2023 at 6:17 AM Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
When the fence can't be added we need to drop the reference.

Suggested-by: Bert Karwatzki <spasswolf@xxxxxx>
Signed-off-by: Christian König <christian.koenig@xxxxxxx>
please add:
Cc: stable@xxxxxxxxxxxxxxx # 6.1.x
When you push this series.

But none of this is in 6.1? That are pure 6.2 changes or am I missing something?

Christian.


Alex

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
index bac7976975bd..dcd8c066bc1f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
@@ -391,8 +391,10 @@ int amdgpu_sync_push_to_job(struct amdgpu_sync *sync, struct amdgpu_job *job)

                 dma_fence_get(f);
                 r = drm_sched_job_add_dependency(&job->base, f);
-               if (r)
+               if (r) {
+                       dma_fence_put(f);
                         return r;
+               }
         }
         return 0;
  }
--
2.34.1





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux