[AMD Official Use Only - General] Probably want to fix that typo from SMDA to SDMA in the subject line before pushing. Kent > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex > Deucher > Sent: Thursday, December 15, 2022 5:11 PM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Bhardwaj, Rajneesh > <Rajneesh.Bhardwaj@xxxxxxx> > Subject: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume > > SDMA 5.x is part of the GFX block so it's controlled via > GFXOFF. Skip suspend as it should be handled the same > as GFX. > > v2: drop SDMA 4.x. That requires special handling. > > Acked-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxx> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index a99b327d5f09..5c0719c03c37 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -3028,6 +3028,12 @@ static int amdgpu_device_ip_suspend_phase2(struct > amdgpu_device *adev) > adev->ip_blocks[i].version->type == > AMD_IP_BLOCK_TYPE_GFX)) > continue; > > + /* SDMA 5.x+ is part of GFX power domain so it's covered by > GFXOFF */ > + if (adev->in_s0ix && > + (adev->ip_versions[SDMA0_HWIP][0] >= IP_VERSION(5, 0, 0)) > && > + (adev->ip_blocks[i].version->type == > AMD_IP_BLOCK_TYPE_SDMA)) > + continue; > + > /* XXX handle errors */ > r = adev->ip_blocks[i].version->funcs->suspend(adev); > /* XXX handle errors */ > -- > 2.38.1
