On Thu, Dec 15, 2022 at 10:05 AM Bhardwaj, Rajneesh <rajneesh.bhardwaj@xxxxxxx> wrote: > > Don't we need a similar check on resume_phase2? The resume code looks to see if the IP was suspended in the first place before trying to resume it so no need. Alex > > Other than that, looks good to me. > > Acked-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxx> > > On 12/14/2022 5:16 PM, Alex Deucher wrote: > > SDMA 5.x is part of the GFX block so it's controlled via > > GFXOFF. Skip suspend as it should be handled the same > > as GFX. > > > > v2: drop SDMA 4.x. That requires special handling. > > > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > index a99b327d5f09..5c0719c03c37 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > @@ -3028,6 +3028,12 @@ static int amdgpu_device_ip_suspend_phase2(struct amdgpu_device *adev) > > adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_GFX)) > > continue; > > > > + /* SDMA 5.x+ is part of GFX power domain so it's covered by GFXOFF */ > > + if (adev->in_s0ix && > > + (adev->ip_versions[SDMA0_HWIP][0] >= IP_VERSION(5, 0, 0)) && > > + (adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_SDMA)) > > + continue; > > + > > /* XXX handle errors */ > > r = adev->ip_blocks[i].version->funcs->suspend(adev); > > /* XXX handle errors */
