[AMD Official Use Only - General] [ABANDON] The changes are not required at the moment. As the patch is not merged I would like to mark this as abandoned. Thanks From: Gao, Likun <Likun.Gao@xxxxxxx> Sent: Tuesday, November 8, 2022 10:14 AM To: Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; S, Shirish <Shirish.S@xxxxxxx> Subject: RE: [PATCH] drm/amdgpu: Add support to clock gating for sdma 5.2.7 [AMD Official Use Only - General] Looks good to me, this patch is Reviewed-by: Likun Gao <Likun.Gao@xxxxxxx<mailto:Likun.Gao@xxxxxxx>> Regards, Likun From: Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel@xxxxxxx<mailto:KrunalkumarMukeshkumar.Patel@xxxxxxx>> Sent: Tuesday, November 8, 2022 11:46 AM To: Deucher, Alexander <Alexander.Deucher@xxxxxxx<mailto:Alexander.Deucher@xxxxxxx>>; Pan, Xinhui <Xinhui.Pan@xxxxxxx<mailto:Xinhui.Pan@xxxxxxx>>; Koenig, Christian <Christian.Koenig@xxxxxxx<mailto:Christian.Koenig@xxxxxxx>>; Gao, Likun <Likun.Gao@xxxxxxx<mailto:Likun.Gao@xxxxxxx>>; Zhang, Hawking <Hawking.Zhang@xxxxxxx<mailto:Hawking.Zhang@xxxxxxx>> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx<mailto:amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; S, Shirish <Shirish.S@xxxxxxx<mailto:Shirish.S@xxxxxxx>> Subject: Re: [PATCH] drm/amdgpu: Add support to clock gating for sdma 5.2.7 [AMD Official Use Only - General] +Likun, Hawking Hi, Can you please help with the review of the patch? Thanks and regards Krunal ________________________________ From: Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel@xxxxxxx<mailto:KrunalkumarMukeshkumar.Patel@xxxxxxx>> Sent: Monday, November 7, 2022 1:35:01 PM To: Deucher, Alexander <Alexander.Deucher@xxxxxxx<mailto:Alexander.Deucher@xxxxxxx>>; Pan, Xinhui <Xinhui.Pan@xxxxxxx<mailto:Xinhui.Pan@xxxxxxx>>; Koenig, Christian <Christian.Koenig@xxxxxxx<mailto:Christian.Koenig@xxxxxxx>> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx<mailto:amd-gfx@xxxxxxxxxxxxxxxxxxxxx> <amd-gfx@xxxxxxxxxxxxxxxxxxxxx<mailto:amd-gfx@xxxxxxxxxxxxxxxxxxxxx>>; S, Shirish <Shirish.S@xxxxxxx<mailto:Shirish.S@xxxxxxx>>; Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel@xxxxxxx<mailto:KrunalkumarMukeshkumar.Patel@xxxxxxx>> Subject: [PATCH] drm/amdgpu: Add support to clock gating for sdma 5.2.7 With this change it will add support for clock gating for sdma 5.2.7 - Additional changes are to re-arrange the chip version sequentially. Signed-off-by: Krunal Patel <krunalkumarmukeshkumar.patel@xxxxxxx<mailto:krunalkumarmukeshkumar.patel@xxxxxxx>> --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c index 809eca54fc61..404b255cb4e0 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c @@ -1647,12 +1647,13 @@ static int sdma_v5_2_set_clockgating_state(void *handle, switch (adev->ip_versions[SDMA0_HWIP][0]) { case IP_VERSION(5, 2, 0): - case IP_VERSION(5, 2, 2): case IP_VERSION(5, 2, 1): + case IP_VERSION(5, 2, 2): + case IP_VERSION(5, 2, 3): case IP_VERSION(5, 2, 4): case IP_VERSION(5, 2, 5): case IP_VERSION(5, 2, 6): - case IP_VERSION(5, 2, 3): + case IP_VERSION(5, 2, 7): sdma_v5_2_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE); sdma_v5_2_update_medium_grain_light_sleep(adev, -- 2.25.1
<<attachment: winmail.dat>>
