Re: [PATCH] drm/amd/display: trigger timing sync only if TG is running

[Rodrigo Siqueira Jordao <Rodrigo.Siqueira@xxxxxxx>]

On 11/21/22 17:14, Aurabindo Pillai wrote:
> [Why&How]
> If the timing generator isnt running, it does not make sense to trigger
> a sync on the corresponding OTG. Check this condition before starting.
> Otherwise, this will cause error like:
>
> *ERROR* GSL: Timeout on reset trigger!
>
> Fixes: 8c7924bdb0fe ("drm/amd/display: Disable phantom OTG after enable for plane disable")
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index 587b04b8712d..0db02e76dcc5 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -2252,6 +2252,12 @@ void dcn10_enable_timing_synchronization(
>   		opp = grouped_pipes[i]->stream_res.opp;
>   		tg = grouped_pipes[i]->stream_res.tg;
>   		tg->funcs->get_otg_active_size(tg, &width, &height);
> +
> +		if (!tg->funcs->is_tg_enabled(tg)) {
> +			DC_SYNC_INFO("Skipping timing sync on disabled OTG\n");
> +			return;
> +		}
> +
>   		if (opp->funcs->opp_program_dpg_dimensions)
>   			opp->funcs->opp_program_dpg_dimensions(opp, width, 2*(height) + 1);
>   	}

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>