Re: [PATCH] Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"

[Luben Tuikov <luben.tuikov@xxxxxxx>]

Reviewed-by: Luben Tuikov <luben.tuikov@xxxxxxx>

Regards,
Luben

On 2022-11-21 12:26, Alex Deucher wrote:
> Ping?
> 
> On Thu, Nov 17, 2022 at 9:49 AM Alex Deucher <alexander.deucher@xxxxxxx> wrote:
>>
>> This reverts commit 5aa663752ff6f844c6bfc97d89231e98884ae769.
>>
>> This causes a blank screen on boot on an Asus G513QY / 6800M laptop.
>>
>> Bug: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F2259&amp;data=05%7C01%7Cluben.tuikov%40amd.com%7C7195e71123944bfc820208dacbe59400%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638046484140489919%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=0WlPsYWutXT%2BdwnEGeZEzceZs8LAqfH8yu%2BGcQiy3uI%3D&amp;reserved=0
>> Cc: Aric Cyr <Aric.Cyr@xxxxxxx>
>> Cc: Tom Chung <chiahsuan.chung@xxxxxxx>
>> Cc: Zhongwei Zhang <Zhongwei.Zhang@xxxxxxx>
>> Cc: Harry Wentland <harry.wentland@xxxxxxx>
>> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
>> ---
>>  drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> index 1c3de3a1671e..049ef31ebf69 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> @@ -1192,7 +1192,7 @@ static void disable_vbios_mode_if_required(
>>
>>                                         if (pix_clk_100hz != requested_pix_clk_100hz) {
>>                                                 core_link_disable_stream(pipe);
>> -                                               pipe->stream->dpms_off = true;
>> +                                               pipe->stream->dpms_off = false;
>>                                         }
>>                                 }
>>                         }
>> --
>> 2.38.1
>>