[AMD Official Use Only - General] Rewed-by: shaoyun liu <shaoyun.liu@xxxxxxx> -----Original Message----- From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex Deucher Sent: Wednesday, November 9, 2022 2:07 PM To: Wan, Gavin <Gavin.Wan@xxxxxxx> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH] drm/amdgpu: Ignore stop rlc on SRIOV environment. On Wed, Nov 9, 2022 at 1:24 PM Gavin Wan <Gavin.Wan@xxxxxxx> wrote: > > For SRIOV, the guest driver should not do stop rlc. The host handles > programing RLC. > > On SRIOV, the stop rlc will be hang (RLC related registers are blocked > by policy) when the RLCG interface is not enabled. > > Signed-off-by: Gavin Wan <Gavin.Wan@xxxxxxx> Acked-by: Alex Deucher <alexander.deucher@xxxxxxx> > Change-Id: Iac31332e2c958aae9506759de1d3a311b5c84942> --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > index 4fe75dd2b329..0e9529b95d35 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > @@ -1517,7 +1517,7 @@ static int smu_disable_dpms(struct smu_context *smu) > } > > if (adev->ip_versions[GC_HWIP][0] >= IP_VERSION(9, 4, 2) && > - adev->gfx.rlc.funcs->stop) > + !amdgpu_sriov_vf(adev) && adev->gfx.rlc.funcs->stop) > adev->gfx.rlc.funcs->stop(adev); > > return ret; > -- > 2.34.1 >
