On Tue, Nov 08, 2022 at 11:50:04AM -0500, Felix Kuehling wrote: > While you're making the pmu list per-device, I'd suggest removing adev from > the pmu entry because it is now redundant. The device is implied by the list > that the entry is on. Instead, add an adev parameter to > init_pmu_entry_by_type_and_add. Or you could move the list_add_tail to > amdgpu_pmu_init and remove "_and_add" from the function name. Sorry if I'm being naive here, but does that mean trying to navigate the list pointers to move from a 'pmu_entry' to an 'adev' (list_first_entry(), etc.)? There are quite a few cases where we're trying to go between 'pmu_entry' and 'adev'. I guess I could turn that into a mini helper. I'll also need to scrounge around a bit to see if I have an amdgpu system around that actually supports PMU. I realized the one I tested on doesn't actually hit this code path... and this would be getting a little less obvious/trivial. > Other than that, the patch looks good to me. Thanks for looking! Brian
