[AMD Official Use Only - General]
Hi Alex.
> -----Original Message-----
> From: Alex Deucher <alexdeucher@xxxxxxxxx>
> Sent: Thursday, November 3, 2022 9:15 PM
> To: Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liang, Richard qi
> <Richardqi.Liang@xxxxxxx>; Huang, Shimmer
> <Shimmer.Huang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Liu, Kun
> <Kun.Liu2@xxxxxxx>
> Subject: Re: [PATCH v3 3/3] drm/amdgpu: remove the DID of Vangogh from
> pciidlist
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Thu, Nov 3, 2022 at 2:24 AM Perry Yuan <Perry.Yuan@xxxxxxx> wrote:
> >
> > change the vangogh family to use IP discovery path to initialize IP
> > list, this needs to remove the DID from the PCI ID list to allow the
> > IP discovery path to set all the IP versions correctly.
>
> As a follow up patch, it may make sense to remove CHIP_VANGOGH entirely
> so no one accidentally tries to use it.
>
> Alex
Sure, I will create some following patches to remove the CHIP_VANGOGH relevant code.
Perry.
>
>
> >
> > Signed-off-by: Perry Yuan <Perry.Yuan@xxxxxxx>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > index 429fcdf28836..9c323405e3bb 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > @@ -1909,9 +1909,6 @@ static const struct pci_device_id pciidlist[] = {
> > {0x1002, 0x73AF, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> CHIP_SIENNA_CICHLID},
> > {0x1002, 0x73BF, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> > CHIP_SIENNA_CICHLID},
> >
> > - /* Van Gogh */
> > - {0x1002, 0x163F, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> CHIP_VANGOGH|AMD_IS_APU},
> > -
> > /* Yellow Carp */
> > {0x1002, 0x164D, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> CHIP_YELLOW_CARP|AMD_IS_APU},
> > {0x1002, 0x1681, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> > CHIP_YELLOW_CARP|AMD_IS_APU},
> > --
> > 2.34.1
> >
