[AMD Official Use Only - General]
Hi Alex.
> -----Original Message-----
> From: Alex Deucher <alexdeucher@xxxxxxxxx>
> Sent: Thursday, November 3, 2022 1:14 AM
> To: Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Liang, Richard qi
> <Richardqi.Liang@xxxxxxx>; Huang, Shimmer
> <Shimmer.Huang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Liu, Kun
> <Kun.Liu2@xxxxxxx>
> Subject: Re: [PATCH v2 2/3] drm/amd/display: change GPU match with IP
> version for Vangogh
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Wed, Nov 2, 2022 at 1:00 PM Perry Yuan <Perry.Yuan@xxxxxxx> wrote:
> >
> > Use ip versions (10,3,1) to match the GPU after Vangogh switched to
> > use IP discovery path.
> >
> > Signed-off-by: Perry Yuan <Perry.Yuan@xxxxxxx>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 1efe7fa5bc58..90636b88d6bf 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -10202,8 +10202,8 @@ int
> amdgpu_dm_process_dmub_aux_transfer_sync(bool is_cmd_aux, struct
> dc_context
> > */
> > bool check_seamless_boot_capability(struct amdgpu_device *adev) {
> > - switch (adev->asic_type) {
> > - case CHIP_VANGOGH:
> > + switch (adev->ip_versions[GC_HWIP][0]) {
> > + case IP_VERSION(10, 3, 1):
>
> How about:
> switch (adev->ip_versions[DCE_HWIP][0]) { case IP_VERSION(3, 0, 1):
>
> Since this code is more relevant to the DC IP than the GC IP. With that fixed,
You are right, The DCE IP is more reasonable to match this.
V3 sent for the fix.
Perry.
> the series is:
> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
>
> > if (!adev->mman.keep_stolen_vga_memory)
> > return true;
> > break;
> > --
> > 2.34.1
> >
