Re: [PATCH 2/2] drm/amdgpu: add Vangogh APU flag to IP discovery path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 1, 2022 at 9:23 AM Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
>
> On Tue, Nov 1, 2022 at 1:16 AM Perry Yuan <Perry.Yuan@xxxxxxx> wrote:
> >
> > Add the missing apu flag for Vangogh when using IP discovery code path
> > to initialize IPs
> >
> > Signed-off-by: Perry Yuan <Perry.Yuan@xxxxxxx>
>
> Swap the order of the patches.  With that, the series is:
> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

Actually, you also need to fix up check_seamless_boot_capability() in
amdgpu_dm.c.  Switch that to an IP version check.

Alex


>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > index 3993e6134914..52a92add12ea 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> > @@ -2161,6 +2161,7 @@ int amdgpu_discovery_set_ip_blocks(struct amdgpu_device *adev)
> >                 break;
> >         case IP_VERSION(10, 3, 1):
> >                 adev->family = AMDGPU_FAMILY_VGH;
> > +               adev->apu_flags |= AMD_APU_IS_VANGOGH;
> >                 break;
> >         case IP_VERSION(10, 3, 3):
> >                 adev->family = AMDGPU_FAMILY_YC;
> > --
> > 2.34.1
> >



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux