RE: [PATCH] drm/amdgpu: disable GFXOFF during compute for GFX11

["Kasiviswanathan, Harish" <Harish.Kasiviswanathan@xxxxxxx>]

[Public]

 

Reviewed-by: Harish Kasiviswanathan  <Harish.Kasiviswanathan@xxxxxxx>

 

From: Deucher, Alexander <Alexander.Deucher@xxxxxxx>
Sent: Thursday, October 27, 2022 9:56 AM
To: Sider, Graham <Graham.Sider@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Kasiviswanathan, Harish <Harish.Kasiviswanathan@xxxxxxx>
Subject: Re: [PATCH] drm/amdgpu: disable GFXOFF during compute for GFX11

 

[Public]

 

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

---

From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Graham Sider <Graham.Sider@xxxxxxx>
Sent: Wednesday, October 26, 2022 4:10 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: Kasiviswanathan, Harish <Harish.Kasiviswanathan@xxxxxxx>; Sider, Graham <Graham.Sider@xxxxxxx>
Subject: [PATCH] drm/amdgpu: disable GFXOFF during compute for GFX11

 

Temporary workaround to fix issues observed in some compute applications
when GFXOFF is enabled on GFX11.

Signed-off-by: Graham Sider <Graham.Sider@xxxxxxx>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index 37db39ba8718..0d764c15f6bf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -706,6 +706,13 @@ int amdgpu_amdkfd_submit_ib(struct amdgpu_device *adev,
 
 void amdgpu_amdkfd_set_compute_idle(struct amdgpu_device *adev, bool idle)
 {
+       /* Temporary workaround to fix issues observed in some
+        * compute applications when GFXOFF is enabled on GFX11.
+        */
+       if (IP_VERSION_MAJ(adev->ip_versions[GC_HWIP][0]) == 11) {
+               pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled");
+               amdgpu_gfx_off_ctrl(adev, idle);
+       }
         amdgpu_dpm_switch_power_profile(adev,
                                         PP_SMC_POWER_PROFILE_COMPUTE,
                                         !idle);
--
2.25.1