Hi YuBiao,
Ah, okay, there's a precedent for such a change then.
Acked-by: Luben Tuikov <luben.tuikov@xxxxxxx>
Regards,
Luben
On 2022-10-19 22:44, Wang, YuBiao wrote:
> Hi Luben,
>
>>> Is this "temporary" as in "we'll revert this commit later", or is it "temporary" as in the code execution itself?
>>> Is this just for this version of the IP or this and any newer versions?
>
> I suppose that it is meant to be reverted later. There is a similar patch in commit c25a7a8bf19a98578ad27aaaa78082276ea1557c which also temporarily skip mes self test only for gc_11.0.3 during mes late init, which was reviewed by @Zhang, Hawking. My patch is to also skip mes self test during gpu recover since self test will also cause failure during reset.
>
> Best Regards,
> Yubiao Wang
>
> -----Original Message-----
> From: Tuikov, Luben <Luben.Tuikov@xxxxxxx>
> Sent: Wednesday, October 19, 2022 11:53 AM
> To: Wang, YuBiao <YuBiao.Wang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx>; Chen, Horace <Horace.Chen@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Xiao, Jack <Jack.Xiao@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Liu, Monk <Monk.Liu@xxxxxxx>; Xu, Feifei <Feifei.Xu@xxxxxxx>; Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>
> Subject: Re: [PATCH] drm/amdgpu: skip mes self test for gc 11.0.3 in recover
>
> On 2022-10-18 23:45, YuBiao Wang wrote:
>> Temporary disable mes self teset for gc 11.0.3 during gpu_recovery.
>>
>
> Is this "temporary" as in "we'll revert this commit later", or is it "temporary" as in the code execution itself?
>
>> Signed-off-by: YuBiao Wang <YuBiao.Wang@xxxxxxx>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> index e0445e8cc342..5b8362727226 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> @@ -5381,7 +5381,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
>> drm_sched_start(&ring->sched, !tmp_adev->asic_reset_res);
>> }
>>
>> - if (adev->enable_mes)
>> + if (adev->enable_mes && adev->ip_versions[GC_HWIP][0] !=
>> +IP_VERSION(11, 0, 3))
>> amdgpu_mes_self_test(tmp_adev);
>
> Is this just for this version of the IP or this and any newer versions?
>
> Regards,
> Luben
>
>>
>> if (!drm_drv_uses_atomic_modeset(adev_to_drm(tmp_adev)) &&
>> !job_signaled) {
