On 2022-09-19 12:43, Alex Deucher wrote:
> The default argument should be enum TRANSFER_FUNCTION_SRGB rather than
> the current boolean value which improperly maps to
> TRANSFER_FUNCTION_BT709.
>
> Commit 9b3d76527f6e ("drm/amd/display: Revert adding degamma coefficients")
> looks to have improperly reverted
> commit d02097095916 ("drm/amd/display: Add regamma/degamma coefficients and set sRGB when TF is BT709")
> replacing the enum value with a boolean value.
>
> Cc: Krunoslav Kovac <Krunoslav.Kovac@xxxxxxx>
> Cc: Jaehyun Chung <jaehyun.chung@xxxxxxx>
> Cc: Zeng Heng <zengheng4@xxxxxxxxxx>
> Fixes: 9b3d76527f6e ("drm/amd/display: Revert adding degamma coefficients")
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
Harry
> ---
> drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
> index 04f7656906ca..447a0ec9cbe2 100644
> --- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
> +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c
> @@ -1692,7 +1692,7 @@ static void apply_degamma_for_user_regamma(struct pwl_float_data_ex *rgb_regamma
> struct pwl_float_data_ex *rgb = rgb_regamma;
> const struct hw_x_point *coord_x = coordinates_x;
>
> - build_coefficients(&coeff, true);
> + build_coefficients(&coeff, TRANSFER_FUNCTION_SRGB);
>
> i = 0;
> while (i != hw_points_num + 1) {
