Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

["Liu, Shaoyun" <Shaoyun.Liu@xxxxxxx>]

Looks OK to me.

Reviewed by : shaoyun.liu <shaoyun.liu@xxxxxxx>

---

From: Chander, Vignesh <Vignesh.Chander@xxxxxxx>
Sent: September 28, 2022 3:03 PM
To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>
Cc: Liu, Shaoyun <Shaoyun.Liu@xxxxxxx>; Chander, Vignesh <Vignesh.Chander@xxxxxxx>
Subject: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist

 

For xgmi sriov, the reset is handled by host driver and hive->reset_domain
is not initialized so need to check if it exists before doing a put.
Signed-off-by: Vignesh Chander <Vignesh.Chander@xxxxxxx>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h
index dc43fcb93eac..f5318fedf2f0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h
@@ -113,7 +113,8 @@ static inline bool amdgpu_reset_get_reset_domain(struct amdgpu_reset_domain *dom
 
 static inline void amdgpu_reset_put_reset_domain(struct amdgpu_reset_domain *domain)
 {
-       kref_put(&domain->refcount, amdgpu_reset_destroy_reset_domain);
+       if (domain)
+               kref_put(&domain->refcount, amdgpu_reset_destroy_reset_domain);
 }
 
 static inline bool amdgpu_reset_domain_schedule(struct amdgpu_reset_domain *domain,
--
2.25.1