[AMD Official Use Only - General] Hi Christian, It is because the host driver handles the reset for xgmi sriov case. I will update the commit body as For xgmi sriov, the reset is handled by host driver and hive->reset_domain is not initialized so need to check if it exists before doing a put. Regards, VIGNESH CHANDER Senior Software Development Engineer | AMD SW GPU Virtualization ---------------------------------------------------------------------------------------------------------------------------------- 1 Commerce Valley Dr E, Markham, ON L3T 7X6, Canada -----Original Message----- From: Christian König <ckoenig.leichtzumerken@xxxxxxxxx> Sent: Wednesday, September 28, 2022 1:45 PM To: Chander, Vignesh <Vignesh.Chander@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Liu, Shaoyun <Shaoyun.Liu@xxxxxxx> Subject: Re: [PATCH] drm/amdgpu: Skip put_reset_domain if it doesnt exist Am 28.09.22 um 19:43 schrieb Vignesh Chander: > For sriov, the reset domain is no longer created so need to check if it > exists before doing a put. Why is the reset domain no longer created for SRIOV? Regards, Christian. > Signed-off-by: Vignesh Chander <Vignesh.Chander@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c > index 47159e9a0884..80fb6ef929e5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c > @@ -217,7 +217,8 @@ static void amdgpu_xgmi_hive_release(struct kobject *kobj) > struct amdgpu_hive_info *hive = container_of( > kobj, struct amdgpu_hive_info, kobj); > > - amdgpu_reset_put_reset_domain(hive->reset_domain); > + if (hive->reset_domain) > + amdgpu_reset_put_reset_domain(hive->reset_domain); > hive->reset_domain = NULL; > > mutex_destroy(&hive->hive_lock);
