Re: [PATCH] drm/amdgpu: use dirty framebuffer helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 06.09.22 um 21:57 schrieb Hamza Mahfooz:
Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use
drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs
struct.

drm_atomic_helper_dirtyfb() creates a new atomic commit for the frambuffer's planes. Drivers can then updates these planes' output (e.g., writeback to video memory). I thought that amdgpu simply scans out from the framebuffer's memory regions in VRAM. So I'm curious why this patch is necessary.

Best regards
Thomas


Signed-off-by: Hamza Mahfooz <hamza.mahfooz@xxxxxxx>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index c20922a5af9f..5b09c8f4fe95 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -38,6 +38,7 @@
  #include <linux/pci.h>
  #include <linux/pm_runtime.h>
  #include <drm/drm_crtc_helper.h>
+#include <drm/drm_damage_helper.h>
  #include <drm/drm_edid.h>
  #include <drm/drm_gem_framebuffer_helper.h>
  #include <drm/drm_fb_helper.h>
@@ -496,6 +497,7 @@ bool amdgpu_display_ddc_probe(struct amdgpu_connector *amdgpu_connector,
  static const struct drm_framebuffer_funcs amdgpu_fb_funcs = {
  	.destroy = drm_gem_fb_destroy,
  	.create_handle = drm_gem_fb_create_handle,
+	.dirty = drm_atomic_helper_dirtyfb,
  };
uint32_t amdgpu_display_supported_domains(struct amdgpu_device *adev,

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux