[AMD Official Use Only - General]
Good point, thanks for the review. I will send a new one.
Thanks,
Candice
-----Original Message-----
From: Kuehling, Felix <Felix.Kuehling@xxxxxxx>
Sent: Thursday, September 8, 2022 11:54 AM
To: Li, Candice <Candice.Li@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] drm/amdgpu: Enable full reset when RAS is supported on gc v11_0_0
Am 2022-09-07 um 21:10 schrieb Candice Li:
> Enable full reset for RAS supported configuration on gc v11_0_0.
>
> Signed-off-by: Candice Li <candice.li@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/soc21.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc21.c b/drivers/gpu/drm/amd/amdgpu/soc21.c
> index a26c5723c46e27..81f32d77c98cd5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc21.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc21.c
> @@ -421,6 +421,10 @@ static bool soc21_need_full_reset(struct amdgpu_device *adev)
> {
> switch (adev->ip_versions[GC_HWIP][0]) {
> case IP_VERSION(11, 0, 0):
> + if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__UMC))
> + return true;
> + else
> + return false;
Is there a reason why this can't be written simply as
return amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__UMC);
Regards,
Felix
> case IP_VERSION(11, 0, 2):
> return false;
> default:
