[AMD Official Use Only - General]
> -----Original Message-----
> From: Mahfooz, Hamza <Hamza.Mahfooz@xxxxxxx>
> Sent: Wednesday, August 31, 2022 1:58 PM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Mahfooz, Hamza <Hamza.Mahfooz@xxxxxxx>; Wentland, Harry
> <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo) <Sunpeng.Li@xxxxxxx>;
> Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; David
> Airlie <airlied@xxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; Kazlauskas,
> Nicholas <Nicholas.Kazlauskas@xxxxxxx>; Lei, Jun <Jun.Lei@xxxxxxx>;
> Somasundaram, Meenakshikumar
> <Meenakshikumar.Somasundaram@xxxxxxx>; Lee, Alvin
> <Alvin.Lee2@xxxxxxx>; Leung, Martin <Martin.Leung@xxxxxxx>; Tam,
> Samson <Samson.Tam@xxxxxxx>; Hung, Alex <Alex.Hung@xxxxxxx>;
> Aberback, Joshua <Joshua.Aberback@xxxxxxx>; Liu, Wenjing
> <Wenjing.Liu@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-
> devel@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH] drm/amd/display: fix indentation in
> commit_planes_for_stream()
>
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this
> ‘if’ clause does not guard... [-Wmisleading-indentation]
> 3508 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this
> statement, but the latter is misleadingly indented as if it were guarded by the
> ‘if’
> 3510 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@xxxxxxx>
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
> b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..6c4948916e7e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3505,11 +3505,11 @@ static void commit_planes_for_stream(struct dc
> *dc,
> top_pipe_to_program-
> >stream_res.tg);
> }
>
> - if (update_type != UPDATE_TYPE_FAST)
> + if (update_type != UPDATE_TYPE_FAST) {
> dc->hwss.post_unlock_program_front_end(dc, context);
> - if (update_type != UPDATE_TYPE_FAST)
> - if (dc->hwss.commit_subvp_config)
> - dc->hwss.commit_subvp_config(dc,
> context);
> + if (dc->hwss.commit_subvp_config)
> + dc->hwss.commit_subvp_config(dc, context);
> + }
>
> /* Since phantom pipe programming is moved to
> post_unlock_program_front_end,
> * move the SubVP lock to after the phantom pipes have been setup
> --
> 2.37.2
