Re: [PATCH 2/2] drm/amd/display: fix documentation for amdgpu_dm_update_freesync_caps()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

On Tue, 30 Aug 2022 09:32:17 -0400 Alex Deucher <alexander.deucher@xxxxxxx> wrote:
>
> Document missing parameter.
> 
> Fixes: 8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 15d51d300b34..4e24b75efcfe 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -9938,6 +9938,7 @@ static int parse_hdmi_amd_vsdb(struct amdgpu_dm_connector *aconnector,
>   * amdgpu_dm_update_freesync_caps - Update Freesync capabilities
>   *
>   * @aconnector: Connector to query.
> + * @edid: EDID from monitor
>   *
>   * Amdgpu supports Freesync in DP and HDMI displays, and it is required to keep
>   * track of some of the display information in the internal data struct used by
> -- 
> 2.37.1
> 

That is not the problem I reported (though that also needed fixing)

I reported:

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9951: warning: Excess function parameter 'aconnector' description in 'amdgpu_dm_update_freesync_caps'

The parameter is actually "connector" (no 'a'), so the line above the
one you added needs fixing as well.

-- 
Cheers,
Stephen Rothwell

Attachment: pgpktRF1sNETW.pgp
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux