I think so, we indeed need a new message indicating suspend, e.g. runtime suspend has completed. I will provide a new patch for this.
Regards,
Guchun
-----Original Message-----
From: Quan, Evan <Evan.Quan@xxxxxxx>
Sent: Thursday, August 25, 2022 3:17 PM
To: Chen, Guchun <Guchun.Chen@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>
Subject: RE: [PATCH] drm/amdgpu: use dev_info to benifit mGPU case
[AMD Official Use Only - General]
Here "free PSP TMR buffer" seems having some special meanings (a marker that indicates suspending is on-going).
Better to redesign the prompts for suspending.
Anyway, the patch is reviewed-by: Evan Quan <evan.quan@xxxxxxx>
Evan
> -----Original Message-----
> From: Chen, Guchun <Guchun.Chen@xxxxxxx>
> Sent: Thursday, August 25, 2022 2:26 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>;
> Quan, Evan <Evan.Quan@xxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>
> Cc: Chen, Guchun <Guchun.Chen@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: use dev_info to benifit mGPU case
>
> 'free PSP TMR buffer' happens in suspend, but sometimes in mGPU
> config, it mixes with PSP resume log printing from another GPU, which
> is confusing. So use dev_info instead of DRM_INFO for printing.
>
> [drm] PSP is resuming...
> [drm] reserve 0xa00000 from 0x877e000000 for PSP TMR amdgpu
> 0000:e3:00.0: amdgpu: GECC is enabled amdgpu 0000:e3:00.0: amdgpu:
> SECUREDISPLAY: securedisplay ta ucode is not available amdgpu
> 0000:e3:00.0: amdgpu: SMU is resuming...
> amdgpu 0000:e3:00.0: amdgpu: smu driver if version = 0x00000040, smu
> fw if version = 0x00000041, smu fw program = 0, version = 0x003a5400
> (58.84.0) amdgpu 0000:e3:00.0: amdgpu: SMU driver if version not
> matched amdgpu 0000:e3:00.0: amdgpu: dpm has been enabled amdgpu
> 0000:e3:00.0: amdgpu: SMU is resumed successfully!
> [drm] DMUB hardware initialized: version=0x02020014 [drm] free PSP TMR
> buffer [drm] kiq ring mec 2 pipe 1 q 0
>
> Signed-off-by: Guchun Chen <guchun.chen@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 1036446abc30..c932bc148554 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -812,7 +812,7 @@ static int psp_tmr_unload(struct psp_context *psp)
> struct psp_gfx_cmd_resp *cmd = acquire_psp_cmd_buf(psp);
>
> psp_prep_tmr_unload_cmd_buf(psp, cmd);
> - DRM_INFO("free PSP TMR buffer\n");
> + dev_info(psp->adev->dev, "free PSP TMR buffer\n");
>
> ret = psp_cmd_submit_buf(psp, NULL, cmd,
> psp->fence_buf_mc_addr);
> --
> 2.25.1
