A while ago, I sent a patch removing some entries from the struct vba_vars_st [1]. At that time, I used git grep and checked if they were used anywhere else manually. But the struct vba_vars_st has more than 900 variables, so git grep every variable is a pretty huge work. So, I grabbed all the variables' names and put them in a text file, and wrote a bash script to analyze if the variables were used. I ended up finding a bunch of variables that were only assigned but never used. I manually checked the results of the script in order to make sure that no functional changes were made to the code. I only removed variables that were only assigned but never used or variables that were never even mentioned. Best Regards, - Maíra Canal [1] https://lore.kernel.org/amd-gfx/20220630215316.1078841-1-mairacanal@xxxxxxxxxx/T/#u Maíra Canal (16): drm/amd/display: Remove NonUrgentLatencyTolerance VBA variable drm/amd/display: Remove CompBufReservedSpace* VBA variable drm/amd/display: Remove DSCCLK_calculated VBA variable drm/amd/display: Remove AllowDRAMSelfRefreshDuringVBlank VBA variable drm/amd/display: Remove VStartupMargin and FirstMainPlane VBA variables drm/amd/display: Remove ImmediateFlipSupportedSurface VBA variable drm/amd/display: Remove WritebackAllowFCLKChangeEndPosition VBA variable drm/amd/display: Remove some XFC variables from VBA drm/amd/display: Remove SwathWidthCSingleDPP VBA variable drm/amd/display: Remove ModeIsSupported VBA variable drm/amd/display: Remove MPCCombineEnable VBA variable drm/amd/display: Remove NumberOfDP2p0Support VBA variable drm/amd/display: Remove TFinalxFill VBA variable drm/amd/display: Remove MaximumDCCCompressionYSurface VBA variable drm/amd/display: Remove only mencioned once VBA variables drm/amd/display: Remove never used VBA variables .../dc/dml/dcn20/display_mode_vba_20.c | 83 ++----------------- .../dc/dml/dcn20/display_mode_vba_20v2.c | 83 ++----------------- .../dc/dml/dcn21/display_mode_vba_21.c | 75 +---------------- .../dc/dml/dcn30/display_mode_vba_30.c | 43 ++-------- .../dc/dml/dcn31/display_mode_vba_31.c | 26 +----- .../dc/dml/dcn314/display_mode_vba_314.c | 26 +----- .../dc/dml/dcn32/display_mode_vba_32.c | 44 +--------- .../drm/amd/display/dc/dml/display_mode_vba.c | 18 +--- .../drm/amd/display/dc/dml/display_mode_vba.h | 45 ---------- 9 files changed, 30 insertions(+), 413 deletions(-) -- 2.37.1
