On Tue, Jul 26, 2022 at 03:27:54PM +0000, Simon Ser wrote: > Hi, > > plane->state->fb is NULL iff afb is NULL. There is an early return to > make sure the dereferences don't cause a segfault. > Are you talking about this: if (!plane->state->fb && !old_plane_state->fb) return; Should the && be ||? regards, dan carpenter