Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
On Mon, Jul 25, 2022 at 3:29 AM Sun, Roy <Roy.Sun@xxxxxxx> wrote:
>
> [AMD Official Use Only - General]
>
> Ping
>
> -----Original Message-----
> From: Roy Sun <Roy.Sun@xxxxxxx>
> Sent: Friday, July 22, 2022 12:57 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Sun, Roy <Roy.Sun@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: Fix the incomplete product number
>
> The comments say that the product number is a 16-digit HEX string so the buffer needs to be at least 17 characters to hold the NUL terminator. Expand the buffer size to 20 to avoid the alignment issues.
>
> The comment:Product number should only be 16 characters. Any more,and something could be wrong. Cap it at 16 to be safe
>
> Signed-off-by: Roy Sun <Roy.Sun@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 9f729a648005..187e3dae3965 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -1019,7 +1019,7 @@ struct amdgpu_device {
> bool psp_sysfs_en;
>
> /* Chip product information */
> - char product_number[16];
> + char product_number[20];
> char product_name[AMDGPU_PRODUCT_NAME_LEN];
> char serial[20];
>
> --
> 2.34.1
