Hi all, On Mon, 25 Jul 2022 07:41:09 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxx> wrote: > > On Fri, 22 Jul 2022 14:12:44 -0400 Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > > > > On Fri, Jul 22, 2022 at 1:56 PM Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx> wrote: > > > > > > When we use the allmodconfig option we see the following error: > > > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull': > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] > > > 3799 | } // ModeSupportAndSystemConfigurationFull > > > > > > This commit fixes this issue by moving part of the mode support > > > operation from ModeSupportAndSystemConfigurationFull to a dedicated > > > function. > > > > > > Cc: Harry Wentland <harry.wentland@xxxxxxx> > > > Cc: Alex Deucher <alexander.deucher@xxxxxxx> > > > Cc: Aurabindo Pillai <aurabindo.pillai@xxxxxxx> > > > Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > > Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx> > > > > Thanks for sorting this out! > > Acked-by: Alex Deucher <alexander.deucher@xxxxxxx> > > Tested-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > > Also, after applying the above patch, the following commits are no > longer needed: > > 987949933127 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule > 8f08cd32b767 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport > 5d526d124fe3 drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath > f6ceebcc7825 drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration > > and could be reverted (or removed). Actually, they are now: 2623c2c90981 drm/amd/display: reduce stack for dml32_CalculatePrefetchSchedule 7d5c4fd7c543 drm/amd/display: reduce stack for dml32_CalculateWatermarksMALLUseAndDRAMSpeedChangeSupport 65f946cee7be drm/amd/display: reduce stack for dml32_CalculateVMRowAndSwath d35fa7f64f4f drm/amd/display: reduce stack for dml32_CalculateSwathAndDETConfiguration -- Cheers, Stephen Rothwell
Attachment:
pgpibyXdN9Yzp.pgp
Description: OpenPGP digital signature
