[AMD Official Use Only - General] Thanks comment, I will change it. -----Original Message----- From: André Almeida <andrealmeid@xxxxxxxxxx> Sent: Thursday, July 21, 2022 9:11 PM To: Guo, Shikai <Shikai.Guo@xxxxxxx> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Liang, Prike <Prike.Liang@xxxxxxx>; Quan, Evan <Evan.Quan@xxxxxxx> Subject: Re: [PATCH] drm/amd/pm: Add get_gfx_off_status interface Hi Shikai, Could you change the commit message to drm/amd/pm: Add get_gfx_off_status interface for yellow carp Otherwise, we are going to have duplicated commit messages for each new architecture supporting get_gfx_off_status. Also, giving that this is the second version of your patch, the subject should be [PATCH v2], and the patch should contain a changelog compared to the previous patch version. Às 05:57 de 21/07/22, shikai.guo@xxxxxxx escreveu: > From: Shikai Guo <Shikai.Guo@xxxxxxx> > > add get_gfx_off_status interface to yellow_carp_ppt_funcs structure. > > Signed-off-by: Shikai Guo <shikai.guo@xxxxxxx> Thanks, André