Re: [PATCH] drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 25, 2022 at 09:30:27AM +0800, Liu, Aaron wrote:
> Fixing compiling error:
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c: In function ‘gmc_v10_0_sw_init’:
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:983:23: error: implicit declaration of function ‘drm_need_swiotlb’ [-Werror=implicit-function-declaration]
>   983 |  adev->need_swiotlb = drm_need_swiotlb(44);
> 
> Signed-off-by: Aaron Liu <aaron.liu@xxxxxxx>

Please revert the one in the amd-staging-drm-next, and squeeze it into the
last one. We would better not separate them as two.

Please make sure the patch can be built successfully at least before push
it.

Thanks,
Ray

> ---
>  drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index f8fa27b7b53b..9ae8cdaa033e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -22,6 +22,9 @@
>   */
>  #include <linux/firmware.h>
>  #include <linux/pci.h>
> +
> +#include <drm/drm_cache.h>
> +
>  #include "amdgpu.h"
>  #include "amdgpu_atomfirmware.h"
>  #include "gmc_v10_0.h"
> -- 
> 2.37.0
> 



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux