The functions dml30_CalculateWriteBackDISPCLK and dml31_CalculateWriteBackDISPCLK are identical. Therefor, to avoid code duplication, replace dml31_CalculateWriteBackDISPCLK by dml30_CalculateWriteBackDISPCLK Signed-off-by: Maíra Canal <mairacanal@xxxxxxxxxx> --- v1 -> v2: - Describe changes in imperative mood (André Almeida). --- .../dc/dml/dcn31/display_mode_vba_31.c | 24 ++----------------- .../dc/dml/dcn31/display_mode_vba_31.h | 11 --------- 2 files changed, 2 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c index 3fab19134480..3bc529f0b0fc 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c @@ -2085,7 +2085,7 @@ static void DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerforman if (v->WritebackEnable[k]) { v->WritebackDISPCLK = dml_max( v->WritebackDISPCLK, - dml31_CalculateWriteBackDISPCLK( + dml30_CalculateWriteBackDISPCLK( v->WritebackPixelFormat[k], v->PixelClock[k], v->WritebackHRatio[k], @@ -3470,26 +3470,6 @@ static double CalculateTWait(unsigned int PrefetchMode, double DRAMClockChangeLa } } -double dml31_CalculateWriteBackDISPCLK( - enum source_format_class WritebackPixelFormat, - double PixelClock, - double WritebackHRatio, - double WritebackVRatio, - unsigned int WritebackHTaps, - unsigned int WritebackVTaps, - long WritebackSourceWidth, - long WritebackDestinationWidth, - unsigned int HTotal, - unsigned int WritebackLineBufferSize) -{ - double DISPCLK_H, DISPCLK_V, DISPCLK_HB; - - DISPCLK_H = PixelClock * dml_ceil(WritebackHTaps / 8.0, 1) / WritebackHRatio; - DISPCLK_V = PixelClock * (WritebackVTaps * dml_ceil(WritebackDestinationWidth / 6.0, 1) + 8.0) / HTotal; - DISPCLK_HB = PixelClock * WritebackVTaps * (WritebackDestinationWidth * WritebackVTaps - WritebackLineBufferSize / 57.0) / 6.0 / WritebackSourceWidth; - return dml_max3(DISPCLK_H, DISPCLK_V, DISPCLK_HB); -} - static double CalculateWriteBackDelay( enum source_format_class WritebackPixelFormat, double WritebackHRatio, @@ -4055,7 +4035,7 @@ void dml31_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l if (v->WritebackEnable[k] == true) { v->WritebackRequiredDISPCLK = dml_max( v->WritebackRequiredDISPCLK, - dml31_CalculateWriteBackDISPCLK( + dml30_CalculateWriteBackDISPCLK( v->WritebackPixelFormat[k], v->PixelClock[k], v->WritebackHRatio[k], diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.h b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.h index 90be612f26b2..654362adcaa9 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.h +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.h @@ -28,16 +28,5 @@ void dml31_recalculate(struct display_mode_lib *mode_lib); void dml31_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib); -double dml31_CalculateWriteBackDISPCLK( - enum source_format_class WritebackPixelFormat, - double PixelClock, - double WritebackHRatio, - double WritebackVRatio, - unsigned int WritebackHTaps, - unsigned int WritebackVTaps, - long WritebackSourceWidth, - long WritebackDestinationWidth, - unsigned int HTotal, - unsigned int WritebackLineBufferSize); #endif /* __DML31_DISPLAY_MODE_VBA_H__ */ -- 2.36.1