Hi Siqueira :) Às 15:16 de 15/07/22, Rodrigo Siqueira escreveu: > [Why] > The amdgpu_dm file contains most of the code that works as an interface > between DRM API and DC. As a result, this file becomes very large since > it comprises multiple abstractions such as CRTC manipulation. > > [How] > This commit extracts the CRTC code to its specific file named > amdgpu_dm_crtc. This change does not change anything inside the > functions; the only exception is converting some static functions to a > global function. > > Reviewed-by: Harry Wentland <Harry.Wentland@xxxxxxx> > Acked-by: Alan Liu <HaoPing.Liu@xxxxxxx> > Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx> > --- [...] > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c > new file mode 100644 > index 000000000000..a9413acfe4dc > --- /dev/null > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c > @@ -0,0 +1,463 @@ > +// SPDX-License-Identifier: MIT > +/* > + * Copyright 2022 Advanced Micro Devices, Inc. > + * > + * Permission is hereby granted, free of charge, to any person obtaining a > + * copy of this software and associated documentation files (the "Software"), > + * to deal in the Software without restriction, including without limitation > + * the rights to use, copy, modify, merge, publish, distribute, sublicense, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + * > + * Authors: AMD > + * > + */ > +#include <drm/drm_vblank.h> > +#include <drm/drm_atomic_helper.h> > + > +#include "dc.h" > +#include "amdgpu.h" > +#include "amdgpu_dm_psr.h" > +#include "amdgpu_dm_crtc.h" > +#include "amdgpu_dm_plane.h" > +#include "amdgpu_dm_trace.h" > +#include "amdgpu_dm_debugfs.h" > + It's a good idea do keep includes ordered like +#include <drm/drm_atomic_helper.h> +#include <drm/drm_vblank.h> + +#include "amdgpu.h" +#include "amdgpu_dm_crtc.h" +#include "amdgpu_dm_debugfs.h" +#include "amdgpu_dm_plane.h" +#include "amdgpu_dm_psr.h" +#include "amdgpu_dm_trace.h" +#include "dc.h" because it's easier to check for duplicates and prevents the need for fixes like this in the future: https://gitlab.freedesktop.org/agd5f/linux/-/commit/b7be3ae759160aa3355ebeb0583f67fb9bda4dae
