Re: [PATCH 1/2] drm/amdgpu: drop non-necessary call trace dump

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 20.07.22 um 11:06 schrieb Evan Quan:
This extra call trace dump comes out in every gpu reset.
And it gives people a wrong impression that something
went wrong. Although actually there was not.

Signed-off-by: Evan Quan <evan.quan@xxxxxxx>
Change-Id: I884af405b6b3cd52b9024408a21fd39811a01f4d

Acked-by: Christian König <christian.koenig@xxxxxxx>

And please guys don't add calls to dump_stack() in the future. That's really not supposed to be here.

Thanks,
Christian.

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index b79ee4ffb879..1b1a70a6da18 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -4667,7 +4667,6 @@ static int amdgpu_reset_reg_dumps(struct amdgpu_device *adev)
  	int i;
lockdep_assert_held(&adev->reset_domain->sem);
-	dump_stack();
for (i = 0; i < adev->num_regs; i++) {
  		adev->reset_dump_reg_value[i] = RREG32(adev->reset_dump_reg_list[i]);




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux