On Tue, Jul 19, 2022 at 4:32 AM Mike Lothian <mike@xxxxxxxxxxxxxx> wrote: > > With this patch applied on Linus's tree 5.18-rc7 I get the following warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1367:20: warning: > unused variable 'pd' [-Wunused-variable] > struct amdgpu_bo *pd = vm->root.bo; > ^ > 1 warning generated. > > It does fix the nullpointer though :D I fixed that up when I pulled the patch in. Alex > > > On Fri, 8 Jul 2022 at 02:55, xinhui pan <xinhui.pan@xxxxxxx> wrote: > > > > That has been done in BO release notify. > > > > Signed-off-by: xinhui pan <xinhui.pan@xxxxxxx> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > index 0f9811d02f61..49536fa8d269 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > @@ -1583,11 +1583,6 @@ void amdgpu_amdkfd_gpuvm_destroy_cb(struct amdgpu_device *adev, > > if (!process_info) > > return; > > > > - /* Release eviction fence from PD */ > > - amdgpu_bo_reserve(pd, false); > > - amdgpu_bo_fence(pd, NULL, false); > > - amdgpu_bo_unreserve(pd); > > - > > /* Update process info */ > > mutex_lock(&process_info->lock); > > process_info->n_vms--; > > -- > > 2.34.1 > >
