Re: [PATCH v2] drm/amdgpu: add HW_IP_VCN_UNIFIED type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 15.07.22 um 16:44 schrieb Ruijing Dong:
Define HW_IP_VCN_UNIFIED type the same as HW_IP_VCN_ENC.

VCN4 support for libdrm needs a new definition for
the unified queue, so that it can align to the kernel.

link: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/245/commits

Signed-off-by: Ruijing Dong <ruijing.dong@xxxxxxx>
---
  include/uapi/drm/amdgpu_drm.h | 1 +
  1 file changed, 1 insertion(+)

diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index 18d3246d636e..fe33db8441bc 100644
--- a/include/uapi/drm/amdgpu_drm.h
+++ b/include/uapi/drm/amdgpu_drm.h
@@ -560,6 +560,7 @@ struct drm_amdgpu_gem_va {
  #define AMDGPU_HW_IP_UVD_ENC      5
  #define AMDGPU_HW_IP_VCN_DEC      6
  #define AMDGPU_HW_IP_VCN_ENC      7
+#define AMDGPU_HW_IP_VCN_UNIFIED  AMDGPU_HW_IP_VCN_ENC

Why exactly do we need a new define for this? Essentially the encode queue is extended with new functionality, isn't it?

So I think we should just stick to AMDGPU_HW_IP_VCN_ENC and not add an alias for it.

Regards,
Christian.

  #define AMDGPU_HW_IP_VCN_JPEG     8
  #define AMDGPU_HW_IP_NUM          9




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux