Applied. Thanks!
Alex
On Wed, Jul 13, 2022 at 7:34 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> Smatch complains that:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3369 commit_planes_for_stream()
> warn: variable dereferenced before check 'stream' (see line 3114)
>
> The 'stream' pointer cannot be NULL and the check can be removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index dc2c59995a19..76f9af2c5e19 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3366,7 +3366,7 @@ static void commit_planes_for_stream(struct dc *dc,
> top_pipe_to_program->stream_res.tg,
> CRTC_STATE_VACTIVE);
>
> - if (stream && should_use_dmub_lock(stream->link)) {
> + if (should_use_dmub_lock(stream->link)) {
> union dmub_hw_lock_flags hw_locks = { 0 };
> struct dmub_hw_lock_inst_flags inst_flags = { 0 };
>
> --
> 2.35.1
>
