Re: [PATCH] drm/amd/pm: Prevent divide by zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Às 23:01 de 11/07/22, Yefim Barashkin escreveu:
> divide error: 0000 [#1] SMP PTI
> CPU: 3 PID: 78925 Comm: tee Not tainted 5.15.50-1-lts #1
> Hardware name: MSI MS-7A59/Z270 SLI PLUS (MS-7A59), BIOS 1.90 01/30/2018
> RIP: 0010:smu_v11_0_set_fan_speed_rpm+0x11/0x110 [amdgpu]
> 
> Speed is user-configurable through a file.
> I accidentally set it to zero, and the driver crashed.
> 
> Signed-off-by: Yefim Barashkin <mr.b34r@xxxxxxxxxxxx>
> ---


Reviewed-by: André Almeida <andrealmeid@xxxxxxxxxx>



Minor nit, I would write this commit message like this:

Speed is user-configurable through a file. I accidentally set it to
zero, and the driver crashed:

divide error: 0000 [#1] SMP PTI
CPU: 3 PID: 78925 Comm: tee Not tainted 5.15.50-1-lts #1
Hardware name: MSI MS-7A59/Z270 SLI PLUS (MS-7A59), BIOS 1.90 01/30/2018
RIP: 0010:smu_v11_0_set_fan_speed_rpm+0x11/0x110 [amdgpu]

Fix that by checking user input value.



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux