Re: [PATCH 0/4] Fix compilation issues when using i386

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 30, 2022 at 2:46 PM Rodrigo Siqueira
<Rodrigo.Siqueira@xxxxxxx> wrote:
>
> Fix compilation issues when using i386
>
> We recently got feedback from Randy about issues in the x86-32
> compilation.I was able to reproduce a very similar issue by using:
>
> - gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
> - make -j16 ARCH=i386
> - amd-staging-drm-next
>
> I'm able to see these issues:
>
> ERROR: modpost: "__nedf2" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: modpost: "__muldf3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: modpost: "__floatunsidf" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: modpost: "__umoddi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> This patchset addresses each compilation issue in its own patch since I
> want to have an easy way to bisect display code in case of regressions.
> Please, let me know if you see any issue with these changes and if it
> fixes the 32-bit compilation. If you still see compilation issues,
> please, report:
>
> - GCC version
> - Config file
> - Branch
>
> Thanks
> Siqueira
>
> Rodrigo Siqueira (4):
>   drm/amd/display: Fix __umoddi3 undefined for 32 bit compilation
>   drm/amd/display: Fix __floatunsidf undefined for 32 bit compilation
>   drm/amd/display: Fix __muldf3 undefined for 32 bit compilation
>   drm/amd/display: Fix __nedf2 undefined for 32 bit compilation

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

I think this patch is also relevant, if someone can review it as well:
https://patchwork.freedesktop.org/patch/491429/

Alex

>
>  .../amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c  | 15 +++++++++------
>  .../gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c    |  4 +++-
>  drivers/gpu/drm/amd/display/dc/inc/hw/clk_mgr.h   |  2 +-
>  3 files changed, 13 insertions(+), 8 deletions(-)
>
> --
> 2.25.1
>



[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux