Re: [PATCH] drm/amd/display: Re-org and cleanup the redundant code

[Leo Li <sunpeng.li@xxxxxxx>]

On 2022-06-26 06:15, Chandan Vurdigere Nataraj wrote:
> [Why]
> Redundant if-else cases for repeater and non-repeater checks
>
> [How]
> Without changing the core logic, rearranged the code by removing
> redundant checks
>
> Signed-off-by: Chandan Vurdigere Nataraj <chandan.vurdigerenataraj@xxxxxxx>
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 4027f439a5a4..e3254ac05191 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -907,25 +907,17 @@ enum dc_status dp_get_lane_status_and_lane_adjust(
>   	ln_align->raw = dpcd_buf[2];
>   
>   	if (is_repeater(link, offset)) {
> +

With this extra newline dropped,
Reviewed-by: Leo Li <sunpeng.li@xxxxxxx>

Thanks!

>   		DC_LOG_HW_LINK_TRAINING("%s:\n LTTPR Repeater ID: %d\n"
>   				" 0x%X Lane01Status = %x\n 0x%X Lane23Status = %x\n ",
>   			__func__,
>   			offset,
>   			lane01_status_address, dpcd_buf[0],
>   			lane01_status_address + 1, dpcd_buf[1]);
> -	} else {
> -		DC_LOG_HW_LINK_TRAINING("%s:\n 0x%X Lane01Status = %x\n 0x%X Lane23Status = %x\n ",
> -			__func__,
> -			lane01_status_address, dpcd_buf[0],
> -			lane01_status_address + 1, dpcd_buf[1]);
> -	}
> -	lane01_adjust_address = DP_ADJUST_REQUEST_LANE0_1;
>   
> -	if (is_repeater(link, offset))
>   		lane01_adjust_address = DP_ADJUST_REQUEST_LANE0_1_PHY_REPEATER1 +
>   				((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (offset - 1));
>   
> -	if (is_repeater(link, offset)) {
>   		DC_LOG_HW_LINK_TRAINING("%s:\n LTTPR Repeater ID: %d\n"
>   				" 0x%X Lane01AdjustRequest = %x\n 0x%X Lane23AdjustRequest = %x\n",
>   					__func__,
> @@ -935,6 +927,14 @@ enum dc_status dp_get_lane_status_and_lane_adjust(
>   					lane01_adjust_address + 1,
>   					dpcd_buf[lane_adjust_offset + 1]);
>   	} else {
> +
> +		DC_LOG_HW_LINK_TRAINING("%s:\n 0x%X Lane01Status = %x\n 0x%X Lane23Status = %x\n ",
> +			__func__,
> +			lane01_status_address, dpcd_buf[0],
> +			lane01_status_address + 1, dpcd_buf[1]);
> +
> +		lane01_adjust_address = DP_ADJUST_REQUEST_LANE0_1;
> +
>   		DC_LOG_HW_LINK_TRAINING("%s:\n 0x%X Lane01AdjustRequest = %x\n 0x%X Lane23AdjustRequest = %x\n",
>   			__func__,
>   			lane01_adjust_address,