Re: [PATCH v2] drm/amdkfd: fix warning when CONFIG_HSA_AMD_P2P is not set

[Felix Kuehling <felix.kuehling@xxxxxxx>]

Am 2022-06-10 um 11:46 schrieb Alex Deucher:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1542:11:
> warning: variable 'i' set but not used [-Wunused-but-set-variable]
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>

Thank you for taking care of this.

Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 3e240b22ec91..411447357196 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -1539,7 +1539,10 @@ static int kfd_dev_create_p2p_links(void)
>   {
>   	struct kfd_topology_device *dev;
>   	struct kfd_topology_device *new_dev;
> -	uint32_t i, k;
> +#if defined(CONFIG_HSA_AMD_P2P)
> +	uint32_t i;
> +#endif
> +	uint32_t k;
>   	int ret = 0;
>   
>   	k = 0;
> @@ -1553,7 +1556,6 @@ static int kfd_dev_create_p2p_links(void)
>   		return 0;
>   
>   	k--;
> -	i = 0;
>   
>   	/* create in-direct links */
>   	ret = kfd_create_indirect_link_prop(new_dev, k);
> @@ -1562,6 +1564,7 @@ static int kfd_dev_create_p2p_links(void)
>   
>   	/* create p2p links */
>   #if defined(CONFIG_HSA_AMD_P2P)
> +	i = 0;
>   	list_for_each_entry(dev, &topology_device_list, list) {
>   		if (dev == new_dev)
>   			break;